Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating sync-k8s.sh test with correct order of commands #5140

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Updating sync-k8s.sh test with correct order of commands #5140

merged 4 commits into from
Jul 17, 2024

Conversation

gizas
Copy link
Contributor

@gizas gizas commented Jul 16, 2024

  • Bug

What does this PR do?

Fixing build errors of https://buildkite.com/elastic/elastic-agent/builds/10446#0190bb6a-7fbe-4101-8de1-c9de2417af3c

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

How to test this PR locally

Try to run manually the steps of

elastic-agent/.buildkite/scripts/steps/sync-k8s.sh

Line 32 in 94cc1c2

GENERATEKUSTOMIZE=true make ci-create-kustomize

@gizas gizas requested a review from a team as a code owner July 16, 2024 13:42
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 16, 2024

This pull request does not have a backport label. Could you fix it @gizas? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot assigned gizas Jul 16, 2024
@gizas gizas added backport-8.15 Automated backport to the 8.15 branch with mergify backport-v8.14.0 Automated backport with mergify backport Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team and removed backport-skip labels Jul 16, 2024
@jlind23 jlind23 enabled auto-merge (squash) July 16, 2024 13:46
@gizas
Copy link
Contributor Author

gizas commented Jul 17, 2024

/test

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@jlind23 jlind23 merged commit 9fc1eab into main Jul 17, 2024
12 of 13 checks passed
@jlind23 jlind23 deleted the fixing_synck8s branch July 17, 2024 08:59
mergify bot pushed a commit that referenced this pull request Jul 17, 2024
@gizas @mergify
updating sync-k8s.sh test with correct order of commands (#5140)
6007441 
(cherry picked from commit 9fc1eab)
@mergify mergify bot mentioned this pull request Jul 17, 2024
Merged
7 tasks
mergify bot pushed a commit that referenced this pull request Jul 17, 2024
@gizas @mergify
updating sync-k8s.sh test with correct order of commands (#5140)
ff736b1 
(cherry picked from commit 9fc1eab)
@mergify mergify bot mentioned this pull request Jul 17, 2024
Merged
7 tasks
gizas added a commit that referenced this pull request Jul 17, 2024
@mergify @gizas
updating sync-k8s.sh test with correct order of commands (#5140) (#5158)
080a7e4 
(cherry picked from commit 9fc1eab)

Co-authored-by: Andrew Gizas <[email protected]>
gizas added a commit that referenced this pull request Jul 17, 2024
@mergify @gizas
updating sync-k8s.sh test with correct order of commands (#5140) (#5157)
dace077 
(cherry picked from commit 9fc1eab)

Co-authored-by: Andrew Gizas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlind23 jlind23 jlind23 approved these changes

@michalpristas michalpristas Awaiting requested review from michalpristas michalpristas was automatically assigned from elastic/elastic-agent-control-plane

@blakerouse blakerouse Awaiting requested review from blakerouse blakerouse was automatically assigned from elastic/elastic-agent-control-plane

Assignees

@gizas gizas

Labels
backport backport-8.15 Automated backport to the 8.15 branch with mergify backport-v8.14.0 Automated backport with mergify skip-changelog Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gizas @jlind23